fix(Core/Dungeon) Blackrock Depths - Ambassador Flamelash (#1803)

* Boss re-order

* Revert "Boss re-order"

This reverts commit 03289cb064.

* Reworking Ambassador flamelash

- Removed timers
- Scripting the boss properly, missing event and talk emote

* Update boss_ambassador_flamelash.cpp

* Update boss_ambassador_flamelash.cpp

* Ambassador Flamelash reworked

- Burning spirits spawn at the correct places
- When they get close to the boss they die, thus buffing the boss with a stackable buff
- When encounter begins the runes start burning
- Burning Spirits chase the boss around the room

* Missing aggro emote and cleanup

* travis

* Cleaner code

Changed the enum usage to a Vector and iterated over every gameobject entry to make them active or ready.

* Cleanup

Removed not used enum

* types

* Update boss_ambassador_flamelash.cpp

* Added dynamic spawning algorithm

Before this commit, Spirits could be summoned on the same rune.
After this commit Spirits will not be summoned on the same position.

* bad null conversion

* declaration and initialization inside function

changed randomPosition to an Int inside the getValidRandomPosition().

* wrong type declaration

variable needs to be declared outside of while cycle.

* useless variable

* Bugfixing

- New fireblast
- When burning spirits die killed by the player, new event to summon new ones
- Make them aggro the player and attack them

* miss typed ;

* Trying to fix mentioned issues

- If spirits are in combat, keep summoning new ones
- If spirits are in combat, then the boss can't kill them if they get close to them

* IsInCombat typo

* Exploit fixing

* Summoning massive waves fix

* Fixing last issue hopefully

data/sql/updates/pending_db_world/rev_1557266833616361000.sql

@@ -0,0 +1,7 @@
+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1557266833616361000');
+
+
+UPDATE `creature_template` SET `ScriptName`='npc_burning_spirit' WHERE `entry`=9178;
+
+DELETE FROM `creature_text` WHERE `CreatureID` = 9156;
+INSERT INTO `creature_text` (`CreatureID`, `Text`, `Type`, `Probability`, `comment`) VALUES ('9156', 'Your reign of terror ends now! Face your doom mortals!', '14', '100', 'Ambassador_flamelash_aggro');