Files
azerothcore-wotlk/src/server/scripts/Kalimdor
Johaine 5060407598 fix(Scripts/TheBlackMorass): rework time rift event logic (#16535)
* Fix visual crystals

This fixes the crystals not despawning on Medivh's death and being
resummoned after every reset

* Fix summoning circle visual after cleanup

Fix respawn of summoning circle visual NPC
Move respawn to same moment as Medivh respawn

* Fix race condition during script cleanup after event failure

This fixes the bug that rifts still spawn after shield is at 0%,
enabling players to exploit the instance and defeat bosses at their own
pace.

In general, removing rifts schedules spawning of new rifts

After failing the event (shield at 0%) this introduces a race between
rift despawn and (scheduler) cleanup

Fix it by introducing a check if the event has been started and should
still progress.

* Fix softlock of event during break after boss

Make sure that the delay condition is removed if event fails

Meeting certain conditions it was possible to softlock the event by
extending the after-boss-break indefinitely

* Cleanup failed instance without player interaction

This respawns Medivh and re-enables the event 5 minutes after a failure

Retrying the event shouldn't require all players to leave the instance
and to reenter

* Misc cleanups

Remove unused DataTypes

Rename variable to something more self-explanatory

Remove unnecessary checks and make scheduling of rifts more
straightforward

Fix typos
2023-06-18 11:47:27 -03:00
..