azerothcore/azerothcore-wotlk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat(Scripts/Commands): allow achievement add from console for offline players (#25283)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Andrew
2026-03-28 17:30:02 -03:00
committed by GitHub
parent ae6e8e0462
commit 531da1d0b4
3 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
data/sql/updates/pending_db_world/rev_achievement_add_strings.sql Normal file
View File

@@ -0,0 +1,5 @@
-- Achievement add command feedback strings
DELETE FROM `acore_string` WHERE `entry` IN (30126, 30127);
INSERT INTO `acore_string` (`entry`, `content_default`, `locale_koKR`, `locale_frFR`, `locale_deDE`, `locale_zhCN`, `locale_zhTW`, `locale_esES`, `locale_esMX`, `locale_ruRU`) VALUES
(30126, 'Achievement {} ({}) added to player {}.', '업적 {} ({})이(가) 플레이어 {}에게 추가되었습니다.', 'Le haut fait {} ({}) a été ajouté au joueur {}.', 'Erfolg {} ({}) wurde Spieler {} hinzugefügt.', '成就 {} ({}) 已添加给玩家 {}。', '成就 {} ({}) 已新增給玩家 {}。', 'El logro {} ({}) ha sido añadido al jugador {}.', 'El logro {} ({}) ha sido añadido al jugador {}.', 'Достижение {} ({}) добавлено игроку {}.'),
(30127, 'Achievement {} ({}) will be added to player {} on next login.', '업적 {} ({})이(가) 다음 로그인 시 플레이어 {}에게 추가됩니다.', 'Le haut fait {} ({}) sera ajouté au joueur {} à la prochaine connexion.', 'Erfolg {} ({}) wird Spieler {} beim nächsten Login hinzugefügt.', '成就 {} ({}) 将在玩家 {} 下次登录时添加。', '成就 {} ({}) 將在玩家 {} 下次登入時新增。', 'El logro {} ({}) será añadido al jugador {} en el próximo inicio de sesión.', 'El logro {} ({}) será añadido al jugador {} en el próximo inicio de sesión.', 'Достижение {} ({}) будет добавлено игроку {} при следующем входе.');

6
src/server/game/Miscellaneous/Language.h
View File

@@ -1445,6 +1445,10 @@ enum AcoreStrings
LANG_DEBUG_FACTIONCHANGE_GOLD_FAIL = 30122,
LANG_DEBUG_FACTIONCHANGE_GOLD_OK = 30123,
LANG_DEBUG_FACTIONCHANGE_GOLD_NOLIMIT = 30124,
LANG_DEBUG_FACTIONCHANGE_NA = 30125
LANG_DEBUG_FACTIONCHANGE_NA = 30125,
// Achievement commands
LANG_ACHIEVEMENT_ADD_ONLINE = 30126,
LANG_ACHIEVEMENT_ADD_OFFLINE = 30127
};
#endif

26
src/server/scripts/Commands/cs_achievement.cpp
View File

@@ -15,8 +15,10 @@
* with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "AchievementMgr.h"
#include "Chat.h"
#include "CommandScript.h"
#include "Language.h"
#include "Player.h"
using namespace Acore::ChatCommands;
@@ -30,7 +32,7 @@ public:
{
static ChatCommandTable achievementCommandTable =
{
{ "add", HandleAchievementAddCommand, SEC_GAMEMASTER, Console::No },
{ "add", HandleAchievementAddCommand, SEC_GAMEMASTER, Console::Yes },
{ "checkall", HandleAchievementCheckAllCommand, SEC_ADMINISTRATOR, Console::Yes }
};
static ChatCommandTable commandTable =
@@ -40,15 +42,27 @@ public:
return commandTable;
}
static bool HandleAchievementAddCommand(ChatHandler* handler, AchievementEntry const* achievementEntry)
static bool HandleAchievementAddCommand(ChatHandler* handler, AchievementEntry const* achievementEntry, Optional<PlayerIdentifier> player)
{
Player* target = handler->getSelectedPlayer();
if (!target)
if (!player)
player = PlayerIdentifier::FromTargetOrSelf(handler);
if (!player)
{
handler->SendErrorMessage(LANG_NO_CHAR_SELECTED);
handler->SendErrorMessage(LANG_PLAYER_NOT_FOUND);
return false;
}
target->CompletedAchievement(achievementEntry);
if (player->IsConnected())
{
player->GetConnectedPlayer()->CompletedAchievement(achievementEntry);
handler->PSendSysMessage(LANG_ACHIEVEMENT_ADD_ONLINE, achievementEntry->ID, achievementEntry->name[0], player->GetName());
}
else
{
sAchievementMgr->CompletedAchievementForOfflinePlayer(player->GetGUID().GetCounter(), achievementEntry);
handler->PSendSysMessage(LANG_ACHIEVEMENT_ADD_OFFLINE, achievementEntry->ID, achievementEntry->name[0], player->GetName());
}
return true;
}